search

helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API
MIT License
98 stars 62 forks source link

Repeat the request with new auth headers #280

Closed scr4bble closed 3 years ago

scr4bble commented 3 years ago

"If the request fails due to an authentication error, retry again after refreshing the token" The "retry" should happen on the old Request object with new auth headers.

scr4bble commented 3 years ago

Fixing this issue: https://github.com/helpscout/helpscout-api-php/issues/279

scr4bble commented 3 years ago

@bkuhl would you have time for a fast review and merge of this fix? :)

scr4bble commented 3 years ago

Any update on this please?

miguelrs commented 3 years ago

Hey @scr4bble, sorry for the delay. Thanks for submitting this PR! ❤️
We're currently looking into it and making some tests, and will update you as soon as we can.

miguelrs commented 3 years ago

@scr4bble We've merged your changes (after adding a small test for them). Thanks again for submitting the PR and for your patience. Please let us know if you experience any issues.