Remove dependency on QuickenLoans/uri-template

helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API

MIT License

99 stars 62 forks source link

Remove dependency on QuickenLoans/uri-template #303

Closed dhazelett closed 1 year ago

dhazelett commented 1 year ago

QuickenLoans has just made all of their repos private, please remove this depenency asap.

PHP version: 7, 8
SDK version: 3

Current behavior cannot install

Expected behavior install

Steps to reproduce

composer require helpscout/api

helgatheviking commented 1 year ago

I was just going to ask about this (my GH build action failed to download this the first time). an issue template is not necessary in the requires and might make more sense as requires-dev? but going private is entirely different

https://github.com/helpscout/helpscout-api-php/blob/master/composer.json#L17

bkuhl commented 1 year ago

Looks like making the repsoitory private here might've been accidental and it's now public again, however switching as done in this pr seems like the ideal path forward.

bkuhl commented 1 year ago

This has been resolved with v3.6.5