helpscout / hsds-react

Help Scout Design System (HSDS) — React Component Library
MIT License
86 stars 17 forks source link

Add tiny icons for line items #1038

Closed justinwolfe closed 2 years ago

justinwolfe commented 2 years ago

Problem/Feature

For line item rows in the new conversation view design, we needed to add two new icons because (per design) the size of the current icons is not appropriate for use in that context.

So this PR adds those two new icons from @kyliedunkley! 🥳

CleanShot 2022-02-22 at 11 18 23 CleanShot 2022-02-22 at 11 18 53

Note: It was stressed to Kylie that these should be "tiny icons"â„¢. I couldn't find any references to what "tiny icons" means searching in various places and this is the only Icon component I know about (and its size prop is number based rather than small medium large etc), so I assume these go here and maybe that was just some design hazingâ„¢, but if I should be putting them somewhere else or doing something different, let me know!

Guidelines

Make sure the pull request:

justinwolfe commented 2 years ago

💯 will do, thank you!

cloudflare-pages[bot] commented 2 years ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18db0f9
Status: âœ…  Deploy successful!
Preview URL: https://21397c36.hsds-react.pages.dev

View logs