Closed jakubjanczyk closed 2 years ago
Latest commit: |
3a8769c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3d471bb5.hsds-react.pages.dev |
FYI, I was trying to do a release today and ran into some trouble. I'm now on Node 16 and when I was trying to run releases using that, I was getting this 403
from npm
when trying to publish the package and had to temporarily switch back to 12 to be able to publish
May not be an issue once this PR is in and the project is also on Node 16, but wanted to flag as something worth testing!
@justinwolfe Thanks for the information and sorry for the trouble :( I was able to successfully publish beta release from this branch (however I've run into some other issue, but was able to resolve it) and I believe the issue you are seeing is related to one of:
npm publish
has changed in newest npm and there was a need to slightly update the script, see the latest commit)@jakubjanczyk No worries at all—it's awesome that you're doing this. Yep, can confirm my NPM email address is verified, so I bet it was the first thing. Awesome that you've got a fix in!!! 🙌
Thanks @justinwolfe for confirming! Yeah, I'll try to push this PR as soon as possible so we don't run into this issue anymore :)
Problem/Feature
Node v12 is reaching EOL in April, so we want to update to the latest active version (v16). There is no impact to the end users, as Node is used only for building the project.
To test: checkout the branch and check that npm scripts are working (
build
,start
,test
, etc). Usenvm use
to switch to node 16 :)This PR is part of this task: https://helpscout.atlassian.net/browse/JS-218
Guidelines
Make sure the pull request:
proptypes
) Guidelines