Closed Charca closed 2 years ago
Latest commit: |
ba3850c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://cdc630d8.hsds-react.pages.dev |
Hi @Charca ! Can you do me a favour and remove this line? It's unrelated to this PR but is a leftover I forgot to remove and it gives the biggest warning ever when running tests... Thanks!
Thank you all for the review! I've made a couple changes so I'm re-requesting review from you all 🙏
@tinkertrain I've included that one-line change to the Tooltip component as well.
@alexestrada that's correct on your first note! The "thank you" message will show up once this is integrated in the Beacon embed-side.
As for the emoji issue, apparently, the position of native emojis is off by a couple pixels on non-retina monitors...
To be fair, I think it's only noticeable because we're showing them inside a circle in a really small font-size, but still! I've added a fix that I think should take care of it!
Jira Issues
Problem/Feature
This PR adds a new MessageCard Survey variation for Microsurveys. It uses the RateAction for the emoji buttons, with the addition of a new
xl
size in both the RateAction and Emoticon components.It also includes a few updates to the "selected" state of the Thumbs Survey to be consistent with the new designs.
Check it out:
Le gif demó:
Guidelines
Make sure the pull request:
proptypes
) Guidelines