helpscout / proxypack

🎭ProxyPack: Proxy Local Webpack Assets to your Production Domain
MIT License
6 stars 1 forks source link

Fix horizontal scrolling on proxied pages #5

Closed knicklabs closed 5 years ago

knicklabs commented 5 years ago

This update fixes an issue where the banner injected into pages by ProxyPack would exceed the width of the page by 14px causing horizontal scrolling.

Problem

By setting the box-sizing property to border-box, the 14 pixels of padding along the x-axis are subtracted from the width instead of added to it. This removes the 14px of padding on the right of the page that was causing horizontal scrolling.

Solution

tjbo commented 5 years ago

Sweet! Good ole' border box.