search

helpwave / mobile-app

The official helpwave mobile app for android and ios
Mozilla Public License 2.0
8 stars 1 forks source link

use and save authservice identity #428

Closed DasProffi closed 1 year ago

DasProffi commented 1 year ago

Which issues does this pull request close?

closes #425

github-actions[bot] commented 1 year ago

BrowserStack

Commit: 134c32b

helpwave tasks

DasProffi commented 1 year ago

Nice! Code looks good some far, some changes.

Two classes are named similar with similar behaviour: AuthService and AuthenticationService. The AuthService is bounded to an app and the users session: UserService? Gets confusing in the future as well.

I have renamed it to UserSessionService seems appropriate and distinct

florian4f6c6 commented 1 year ago

We should still discuss what to do if an error occurs, e.g. due to a missing internet connection. Currently, the user does not get any feedback if, for example, he presses the login button, but there is no internet connection.

DasProffi commented 1 year ago

We should still discuss what to do if an error occurs, e.g. due to a missing internet connection. Currently, the user does not get any feedback if, for example, he presses the login button, but there is no internet connection.

Thank you for the reminder, will be done in #431