helpwithcovid / covid-volunteers

Organizing and matching volunteers with COVID-19 projects
https://helpwithcovid.com
MIT License
96 stars 76 forks source link

fix: users can upload non image files for projects #217

Closed adrianthedev closed 4 years ago

adrianthedev commented 4 years ago

I agree. I just didn't have time to work on it these past couple of days. I thought this temporary solution is ok until I take a deep dive in the direct-upload gem to see how it works. Forgot to mention this.

adrianthedev commented 4 years ago

I seems that active storage direct upload doesn't support server side validation because the file doesn't go through our app and goes directly to S3.

I'll have to explore different options for client side validation. I recommend you merge this for the moment and create a new issue to refactor this.

Some resources on that:

sradu commented 4 years ago

OK.