helpwithcovid / covid-volunteers

Organizing and matching volunteers with COVID-19 projects
https://helpwithcovid.com
MIT License
96 stars 76 forks source link

[Office hours/ Booking System] design update after first draft #247

Open tinnei opened 4 years ago

tinnei commented 4 years ago

Figma design link: https://www.figma.com/file/7PSJtPUtwrdPRtXbtQFRFZ/helpwithcovid.com?node-id=1498%3A12397


Tasks to be done: 1 - Nav bar ◻️ Add "Your Office Hours" under "Your Account" in header

image

2 - [Office hour index page] ◻️ Update header button to URL ◻️ Update card layout (with new text field added in [create office hour page])

image

3 - [Create office hour page] ◻️ Add new text field "Specify what you would like to help on?" ◻️ Add section displaying current office hours (UX similar to current office hour index page) ◻️ Updated layout for create office hours

image

May have missed details in this write up. For any questions, please let us know over at #hwc-development! (Tag @tinnei / @catliu / @colinjohnson) Thank you so much!!

colin-johnston commented 4 years ago

Deleting an existing slot is super confusing. Can we put a delete action adjacent to edit on time slot hover state?

Screenshot 2020-05-29 11 03 11
colin-johnston commented 4 years ago

I think it's confusing and awkward that I need to make sure to delete the event that is auto created after creating a new slot before clicking 'Create slots' if I don't want to create that additional slot. E.g.

  1. I enter info to create a new slot

    Screenshot 2020-05-29 11 06 38
  2. I click '+' to generate it, and an auto generated slot appears below it

    Screenshot 2020-05-29 11 06 46
  3. If I click 'Create slots' button these two are created right? But I only want the one I intentionally created. So I have to delete the second one.

    Screenshot 2020-05-29 11 06 57

So...I understand how it's intended to work, but it's not how I read the UI when I try it after not looking at it for a week of so. The '+' is the action people will most likely click after entering in slot info. It will be confusing and people will create slots they didn't intend to. I suggest we have 'create slot' and 'add new slot' to the right of each inline form, and 'save slots' at the bottom instead of 'create slots'.

colin-johnston commented 4 years ago

🐞 This is a bug report:

When I created a slot for 2pm on a given day it then shows up as 9pm.

Screenshot 2020-05-29 11 06 38 Screenshot 2020-05-29 11 07 09
colin-johnston commented 4 years ago

There's actually no way to edit a slot, even though there's a link on the slot in the card UI:

  1. click 'edit' on slot in card

    Screenshot 2020-05-29 11 18 17
  2. Land on the OH manage UI—huh?

    Screenshot 2020-05-29 11 18 27
  3. Click the slot again, and no edit...

    Screenshot 2020-05-29 11 18 33

I need to delete and recreate slot to change the time?

sradu commented 4 years ago

These should all be resolved. LMK if anything was missed.