search

helpyio / helpy_imap

Fetch Email from Imap or POP3 server and convert to tickets
MIT License
7 stars 6 forks source link

Cloudinary is used when credentials are filled in even when it is disabled #5

Closed phil8900 closed 5 years ago

phil8900 commented 5 years ago

Hey, as I have some issues with attachments not getting added to the tickets in helpy, I wanted to try Cloudinary to see if that fixes the issue. I filled in my Cloudinary credentials and performed some tests, but the problem persisted so I decided to disable Cloudinary again by using the slider button in the settings. As I was lazy and probably want to turn Cloudinary back on at some point later, I left my details in there.

def cloudinary_enabled? AppSettings['cloudinary.cloud_name'].present? && AppSettings['cloudinary.api_key'].present? && AppSettings['cloudinary.api_secret'].present? end

just checks if the credentials are filled in, but it doesn't check if AppSettings['cloudinary.enabled'] is set at all.

This is probably also present in helpy, and not only in helpy_imap.

Best regards, Philip