helsenorge / structor

FHIR Questionnaire Form Builder
https://static.helsenorge.no/static_skjemabygger/
MIT License
88 stars 34 forks source link

Fixed preview bug and radiobutton bug #436

Closed andreasnp closed 2 years ago

andreasnp commented 2 years ago

The preview bug was caused by that the store constant was placed outside of the FormFillerPreview component. It made the questionnaire only update one time even though Refero re-rendered multiple times.

The radiobutton bug was caused by the Refero-component including Toolkit, which brought with it some styling that overrided the styling in Structor. Refero does not have direct dependencies to Toolkit, but some of it's Helsenorge-packages have dependencies to Toolkit. The solution for now was to override the Toolkit styling. Toolkit is on it's way to be totally replaced with Designsystem-React, so this issue will likely solve itself.

lasaron commented 2 years ago

Remaining bugs that need to be fixed before approval: