`buffrs publish` refuses to publish when the `proto/vendor/` is dirty

helsing-ai / buffrs

Modern protobuf package management

https://crates.io/crates/buffrs

Apache License 2.0

214 stars 12 forks source link

`buffrs publish` refuses to publish when the `proto/vendor/` is dirty #200

Open qsantos opened 10 months ago

qsantos commented 10 months ago

When publishing, Buffrs populates the proto/vendor/ directory. If one attempts to publish again, Buffrs then complains that the repository is dirty. I think Buffrs should either:

clear proto/vendor/ before checking that the repository is clean
ignore proto/vendor/ when checking that the repository is clean

khanism commented 8 months ago

I'm not sure if this was intended and if it is wanted to ignore/filter the messages that lead to buffrs complaining about dirty proto files under vendor. Anyhow since this was a quick one: https://github.com/helsing-ai/buffrs/pull/224

The PR does only include dirty statuses of the files actually being packaged. Should one wanted to add a subdirectory under proto (e.g. submodule that contains additional *.proto files) this solution wouldn't cover that but I'm not sure how much this is relevant as of now.

mara-schulke commented 4 months ago

I think we should get #224 over the line!