search

helsing-ai / buffrs

Modern protobuf package management
https://crates.io/crates/buffrs
Apache License 2.0
207 stars 12 forks source link

Ignoring statuses of synched files under vendor when publishing #224

Closed khanism closed 1 month ago

khanism commented 7 months ago

Regarding issue https://github.com/helsing-ai/buffrs/issues/200 This change adds some options to the check of the repository when publishing your Buffrs project.

When publishing, the statuses of the synched *.proto files under vendor are not included, avoiding the project being dirty as described in the issue

mara-schulke commented 6 months ago

Hi @khanism, thank you for contributing!

Have you seen the work on #217 / https://github.com/helsing-ai/buffrs/commit/78740b149f1e292d33433b1a5bd59ba5da495dd7 ?

I think this issue still exists, but the way we check statuses for git has been changed 😊

If you can rebase and update your implementation I am more than happy to merge this, tysm!

khanism commented 2 months ago

@mara-schulke sorry for the long time of funkstille. Thanks for the remark, I'll update this so we can proceed with this PR :)

khanism commented 1 month ago

Closing because of updated fix in https://github.com/helsing-ai/buffrs/pull/263