hemangshah / HHTabBarView

A lightweight customized tabbar view. 📌
MIT License
154 stars 20 forks source link

Added tips for handling hidden state. #3

Closed batuhansk closed 6 years ago

batuhansk commented 6 years ago

I’m using your library on my current work and i guess, that’s a good point to handle hidden state of tab bar on workflow. But your choice. 🙌🏼 On 1 Feb 2018 Thu at 08:19 Hemang notifications@github.com wrote:

@hemangshah commented on this pull request.

@strawb3rryx7 https://github.com/strawb3rryx7 – thanks for the contribution, but for this PR, I don't understand why we need to write this information in the README file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/pull/3#pullrequestreview-93169613, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLkjZOSwKTl-tnXR4Kfuah0uK1nQ0n7ks5tQUlZgaJpZM4R0B2N .

hemangshah commented 6 years ago

@strawb3rryx7 - Glad to hear that, you're using HHTabBarView. I am only concern if we really need to provide that information inside the README? If yes, can we improve it a bit more understandable with a description that, why we need to write that line inside the viewWillAppear?

Looking forward to hearing from you. And once again, I am happy to have all the contributors to this project as I believe, we all together can provide a classy tabbar solution.

batuhansk commented 6 years ago

Thanks for your quick answers, I discovered that problem, sometimes tab bar being in stuck and always stays on bottom. (that’s disappears visually, tab bar controller’s default tab bar is still stays in there.)

and other issue,

I think it is necessary to make arrangements for positioning the tab bar. I experienced some problems while using auto layout in my work I applied to hacky solutions for fixing issues.

On 1 Feb 2018 Thu at 08:43 Hemang notifications@github.com wrote:

@strawb3rryx7 https://github.com/strawb3rryx7 - Glad to hear that, you're using HHTabBarView. I am only concern if we really need to provide that information inside the README? If yes, can we improve it a bit more understandable with a description that, why we need to write that line inside the viewWillAppear?

Looking forward to hearing from you. And once again, I am happy to have all the contributors to this project as I believe, we all together can provide a classy tabbar solution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/pull/3#issuecomment-362164892, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLkjdCs96-QPg7cwlCGDFjQGJaBPhKeks5tQU8IgaJpZM4R0B2N .

hemangshah commented 6 years ago

@strawb3rryx7 , thanks for the detailed response.

Can you please list all of the issues and their possible solutions so I can make the relevant changes in the tab bar?

batuhansk commented 6 years ago

Of course, I’ll send everything about that when I woken up. 🖐🏼 On 1 Feb 2018 Thu at 09:10 Hemang notifications@github.com wrote:

@strawb3rryx7 https://github.com/strawb3rryx7 , thanks for the detailed response.

Can you please list all of the issues and their possible solutions so I can make the relevant changes in the tab bar?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/pull/3#issuecomment-362168667, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLkjfZy87A6CCJIjNJgSElskrxmOu-lks5tQVU8gaJpZM4R0B2N .

hemangshah commented 6 years ago

Sounds good! Thanks @strawb3rryx7 ✋🏻

batuhansk commented 6 years ago

You’re welcome, we’ll do our best! On 1 Feb 2018 Thu at 09:24 Hemang notifications@github.com wrote:

Sounds good! Thanks @strawb3rryx7 https://github.com/strawb3rryx7

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/pull/3#issuecomment-362170833, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLkjfPavChLbFEg_z4gVH4j-Ypyp3Tnks5tQVidgaJpZM4R0B2N .

hemangshah commented 6 years ago

Hi, @strawb3rryx7 - any updates from you?

batuhansk commented 6 years ago

Hello @hemangshah, Thanks for remind me. I'll send message in few days. I was busy for lots of work :'( Don't worry.

hemangshah commented 6 years ago

Hi @strawb3rryx7 - it would be great if you can send an update now?

hemangshah commented 6 years ago

@strawb3rryx7, please feel free to comment if you want me to reopen.

batuhansk commented 6 years ago

Sorry, I'm really busy to contribute that, but i'm keeping in my mind. I'll reopen. Thanks for reminding again.

2018-03-20 15:25 GMT+03:00 Hemang notifications@github.com:

Closed #3 https://github.com/hemangshah/HHTabBarView/pull/3.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/pull/3#event-1530769403, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLkjbWHr82H34nJkU1fTmj0yg-6E1XNks5tgPU6gaJpZM4R0B2N .