search

hemangshah / HHTabBarView

A lightweight customized tabbar view. 📌
MIT License
154 stars 20 forks source link

Not working with pod #8

Closed chiragpurohit71085 closed 6 years ago

chiragpurohit71085 commented 6 years ago

I tried to use with pod, but when I opened project it says code is developed with swift 2.x, I need to first migrate code using xcode 8

2018-09-12-11-43-52

hemangshah commented 6 years ago

Hi @chiragpurohit71085 , thanks for reporting this. I will check this. Btw, which Xcode you're using?

chiragpurohit71085 commented 6 years ago

Xcode 9.4.1

chiragpurohit71085 commented 6 years ago

Oops also tab index are not proper...

tab_index_issue

hemangshah commented 6 years ago

This occurs in the sample code too?

On Wed, 12 Sep 2018 at 20:18, chiragpurohit71085 notifications@github.com wrote:

Oops also tab index are not proper...

[image: tab_index_issue] https://user-images.githubusercontent.com/15859081/45433022-cddf9180-b69a-11e8-835e-e70efe85606f.gif

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/issues/8#issuecomment-420676491, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKPBAynJki-7xgLf6PJqZRLxQWtjqMAks5uaR7AgaJpZM4WlNaD .

-- Sent from my iPhone

chiragpurohit71085 commented 6 years ago

Hi

Sorry sample code has issue in simulator only On device it is working fine.

On Thu 13 Sep, 2018, 6:23 AM Hemang, notifications@github.com wrote:

This occurs in the sample code too?

On Wed, 12 Sep 2018 at 20:18, chiragpurohit71085 <notifications@github.com

wrote:

Oops also tab index are not proper...

[image: tab_index_issue] < https://user-images.githubusercontent.com/15859081/45433022-cddf9180-b69a-11e8-835e-e70efe85606f.gif

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub < https://github.com/hemangshah/HHTabBarView/issues/8#issuecomment-420676491 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ADKPBAynJki-7xgLf6PJqZRLxQWtjqMAks5uaR7AgaJpZM4WlNaD

.

-- Sent from my iPhone

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/issues/8#issuecomment-420846086, or mute the thread https://github.com/notifications/unsubscribe-auth/APH9iVekFuwruIXj0stgslmeQRQAZDuIks5uaayVgaJpZM4WlNaD .

hemangshah commented 6 years ago

Hi @chiragpurohit71085, I just released a new version of HHTabBarView.

HHTabBarView (2.1.0) successfully published

Please try using it and see if it is working fine for you now?

Feel free to reopen this issue if you still have the same problem.

For new issues, please open a separate issue.

chiragpurohit71085 commented 6 years ago

Hi

Thanks.

On Sun 16 Sep, 2018, 6:16 PM Hemang, notifications@github.com wrote:

Hi @chiragpurohit71085 https://github.com/chiragpurohit71085, I just released a new version of HHTabBarView.

HHTabBarView (2.1.0) successfully published

Please try using it and see if it is working fine for you now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hemangshah/HHTabBarView/issues/8#issuecomment-421758122, or mute the thread https://github.com/notifications/unsubscribe-auth/APH9iZkkn4lLSwC6qV1lAEp3mHBFF6zvks5ubkWBgaJpZM4WlNaD .

gerchicov-bp commented 5 years ago

@hemangshah imported via cocoapods into new project with Swift 4.2, got a lot of errors. Fix it for 4.2 please or specify additional instructions for cocoapods please