hemanth / functional-programming-jargon

Jargon from the functional programming world in simple terms!
http://git.io/fp-jargons
MIT License
18.59k stars 1.02k forks source link

Typo Fixes #120

Closed hycner closed 7 years ago

hycner commented 7 years ago
hycner commented 7 years ago

Welp, nevermind then. Are the leading semicolons intentional as well? I've noticed a few more around the repo

hemanth commented 7 years ago

Are the leading semicolons intentional as well?

^ Not really, let us clean them for now, thanks for the PR.

jethrolarson commented 7 years ago

We're using the javascript standard style which skips semicolons. Run npm test to see the error output

On Sun, Sep 18, 2016, 7:04 PM hemanth.hm notifications@github.com wrote:

Are the leading semicolons intentional as well?

^ Not really, let us clean them for now, thanks for the PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hemanth/functional-programming-jargon/pull/120#issuecomment-247899735, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-4OSz-G6M2RnsoNzKt1MlLF3J17gvks5qre2XgaJpZM4KABx3 .

jethrolarson commented 7 years ago

Leading semicolons are necessary when you start a line with an array literal if you're omitting the trailing ones

On Sun, Sep 18, 2016, 7:42 PM Jethro Larson jethrolarson@gmail.com wrote:

We're using the javascript standard style which skips semicolons. Run npm test to see the error output

On Sun, Sep 18, 2016, 7:04 PM hemanth.hm notifications@github.com wrote:

Are the leading semicolons intentional as well?

^ Not really, let us clean them for now, thanks for the PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hemanth/functional-programming-jargon/pull/120#issuecomment-247899735, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-4OSz-G6M2RnsoNzKt1MlLF3J17gvks5qre2XgaJpZM4KABx3 .

FlorianWendelborn commented 7 years ago

@jethrolarson What about integrating Travis CI with this project? It's free for open source and would show that the tests failed. :smile:

hycner commented 7 years ago

Cool thanks, all! Closing in lieu of info above