search

hemanth / functional-programming-jargon

Jargon from the functional programming world in simple terms!
http://git.io/fp-jargons
MIT License
18.58k stars 1.02k forks source link

Update kleisi-composition comment #232

Closed FJuette closed 1 year ago

FJuette commented 1 year ago

Change the comment for the return value for the kleisi-composition.

In my understanding and in my personal tests

parseAndValidate("999")

must return 999 instead of None. 1. it is a number and 2. the number is positive. Please correct me if I'am wrong.

jethrolarson commented 1 year ago

You're right. I think it used to be composing other validators prior. Maybe parseAndValidate("999") would be more illustrative but this change makes it not wrong so that's a clear improvement.

jsoref commented 12 months ago

It was introduced in #226

(I'm mentioning this because I tried to give this repository as an example to a colleague and we tripped on the example...)