hemanth / nmotw.in

Node Module Of The Week
https://nmotw.in
42 stars 7 forks source link

Smart quotes #24

Closed tolmasky closed 8 years ago

tolmasky commented 8 years ago

Just a heads up I think Jekyll by default smart-quotes which is what's causing this example to give a syntax error: http://nmotw.in/hide-secrets/

I believe adding this to _config.yml will fix it:

kramdown: smart_quotes: ["apos", "apos", "quot", "quot"]

(form http://stackoverflow.com/questions/25596792/how-do-i-turn-off-smart-quotes-in-jekyll )

hemanth commented 8 years ago

@tolmasky Thanks for reporting! Is there something missing here ?

tolmasky commented 8 years ago

Hi I was trying to reproduce this locally but when I download this repo and run jekyll serve I get:

Configuration file: /Users/tolmasky/Desktop/nmotw.in/_config.yml Deprecation: The 'pygments' configuration option has been renamed to 'highlighter'. Please update your config file accordingly. The allowed values are 'rouge', 'pygments' or null.

I've tried changing pigments to hight highlighter but then it just complains that pygments.rb doesn't exist or something. I'm not familiar with Ruby so I'm kind of stuck on figuring out what's going on.

tolmasky commented 8 years ago

So I got it working after some ruby version stuff, but I don't see hide-secrets. Is that one in a branch or something?

tolmasky commented 8 years ago

Oh I see you've tackled it already, is it working for you now? (I still see them as smart on the site itself).

hemanth commented 8 years ago

I had the same problem here and had solved it, but can't recall the fix :/

tolmasky commented 8 years ago

Could you upload the hide-secrets post? I think it didn't actually make it into this commit: https://github.com/hemanth/nmotw.in/commit/92d8fe553b42ff7a1eb0432b6d5209eaa17ea7ff

hemanth commented 8 years ago

Deployed it still the same, strange.

tolmasky commented 8 years ago

Having looked into it more, the reason the smart quotes are still happening is that they are being explicitly added with rubypants. If you take out rubypants it works fine.

hemanth commented 8 years ago

Bingo! That reminded me of this answer.

Thanks! It's fine now.