404 - node-nightly

[bvjebin]

Just tried node-nightly. Following is what I am getting on first time usage of the command node-nightly

{ [HTTPError: Response code 404 (Not Found)] message: 'Response code 404 (Not Found)', host: 'nodejs.org', hostname: 'nodejs.org', method: 'GET', path: '/download/nightly/v7.0.0-nightly201608085111e789e6/node-v7.0.0-nightly201608085111e789e6-darwin-x64.tar.gz', statusCode: 404, statusMessage: 'Not Found', bufferedData: <Buffer > }

What happened to the download link? Why 404? Am I missing something?

I am using Mac El Capitan. Node - v5.2.0 NPM - 3.3.12

[hemanth]

Thanks for reporting .

Yikes, maybe the latest PR broke it.

//cc @bhaveshgohel

P.S: We badly need a test suite here.

[bhaveshgohel]

@hemanth : The latest release for "darwin" Is not updated on official directory yet! Please check: https://nodejs.org/download/nightly/v7.0.0-nightly201608085111e789e6/

[hemanth]

Yup, just noticed!

We better display a message in this case?

[hemanth]

@bhaveshgohel @bvjebin re-tweet ;)

[bhaveshgohel]

@hemanth It's bit Hacky! i know, but It will be nice if we can somehow download the 2nd latest release and at upgrade if we get 404 we can prompt it like no update available, and download and prompt it next time when we get. What you think? How can we get the previous release?

[hemanth]

Yes, I understand it's hacky, but looking for a quick fix.

Currently we are using node-nightly-version to get the latest version, we have two options:

• Create node-nightly-versions or
• Create options for node-nightly-version to return all the version.

[bhaveshgohel]

One quick fix we can do right now is always download the 2nd latest version and if user need the latest he can add "--force-upgrade" kind of flag ?

small code change here :

text.split('\n')[1].split('\t')[0])

to

text.split('\n')[2].split('\t')[0])

[hemanth]

I would vote for throwing an error saying we don't have a build yet for this version of OS.

[bhaveshgohel]

Downgrading one version will be good, as he can at-least use "node-nightly"! #IMO And Additionally we can throw error too if we can't get 2nd latest release for that OS.

[hemanth]

okies we can do that, but we need to rename --force-upgrade to something better.

[tarungarg546]

If i were to say, i would personally prefer more interaction in this case.

I would like to see my console like this

Downloading the nightly version, hang on...
Oops! Seems like there is no build ${version} available for ${your-os}
Would you like to fallback to older version(Y/N)?
..${Then do  stuff here} 

[bhaveshgohel]

@tarungarg546 Good idea! :+1:

[vigneshshanmugam]

I would go for a env variable or args to specify the version to download.

would address most cases.

[tarungarg546]

@vigneshshanmugam but thing is most people dont know abut nightly builds and from where to get them, that's why may be we have this kind of tool available. If they knew version and all they could just go on the url and download them. it's just my view

[cswl]

If the changes don't affect a platform they are not built.. nightly doesn't necessarily mean a new build every night.

I think we should download whatever the latest version of nightly available for the platform. That is still the latest nightly available for that platform.

This would require some change in the node-nightly-version. If we parse index.json instead of index.tab we can traverse until we find the version for the platform.

[bhaveshgohel]

@hemanth Just check the https://nodejs.org/download/nightly/ they haven't uploaded binaries for linux and MAC since 8th august to till date. I guess the approach i was suggesting for fetching 2nd latest might not work now. And it's good if we just throw an Error saying the build is not available yet. and give them chance to specify the build version they want to download with "--get" or "--fetch" argument or after throwing error where user will specifying build number like "201608104878e1c0e5" serched from https://nodejs.org/download/nightly/ . Whats your thoughts on this?

//cc @tarungarg546

[hemanth]

I feel it would be great to find the latest version in the directory structure for a given os version and have 0 inputs from the user.

As @cswl was mentioning.

[tarungarg546]

+1 @hemanth @cswl

[vladikoff]

Is there a workaround until there is a released fix?

[hemanth]

Okies, now we can integrate this? 😇

[hemanth]

I have updated the master with the latest changes, yet to do a release, if someone can confirm me that it looks fine on windows, we can do it!

[bhaveshgohel]

@hemanth Please check https://github.com/hemanth/node-nightly-version/commit/9acedb40e536e93b50dadf975a161ff6c98a66cf#commitcomment-18666823

[tarungarg546]

Tracking link https://github.com/hemanth/node-nightly-version/pull/3

[hemanth]

Okies, all is well for a version bump now?

I have patched it, @bhaveshgohel could you please verify on windows now?

[tarungarg546]

+@bvjebin @vladikoff

[hemanth]

We so badly need a @here or @all 🤔

[bhaveshgohel]

@hemanth @tarungarg546 Sorry for the late reply, I was getting undefined version on windows, so add some changes and sent two PR, Please Track the update here: https://github.com/hemanth/node-nightly-version/issues/4

PR1 : https://github.com/hemanth/node-nightly-versions/pull/2 PR2: https://github.com/hemanth/node-nightly-version/pull/5

[hemanth]

Thanks!

I think with this, we must be good for a minor version bump for node-nigthly, let us close this issue ASAP!

[bhaveshgohel]

Yes! :+1:

[hemanth]

Hmm 🤔

[bhaveshgohel]

I get the same error after complete clean install :confused:

known bug : https://github.com/npm/npm/issues/9633 (╯°□°）╯︵ ┻━┻

[hemanth]

Green at last! Phew!

[hemanth]

node-nightly@1.6.0 fixes this, thanks for reporting.

[hemanth]

TODO: Write the changelog and tweet about it!

Thanks everyone for joining hands on this, I would need your tweeter handles please.

[bhaveshgohel]

🐦 On Twitter as ibhaveshgohel

[tarungarg546]

Tarun_garg2

[hemanth]

I just added a change log History file.

I wonder if @cswl is on twitter...🤔