hemanth / ramda-repl

Ramdajs REPL.
MIT License
28 stars 6 forks source link

New user greeting #7

Closed ythecombinator closed 8 years ago

ythecombinator commented 8 years ago

Hey, nothing too special 'bout this PR, it just adds a fancier user greeting.

The proposed new user greeting is based on ramda + REPL logo I drew - which uses the RBNo2.1a Book font:

Logo

Then I made an ASCII-alike version of the logo above:

 λλλλλλλλ                                         
λλλλλλλλλλ                                        
λλ λλλλλλλλλλλ                                    
λλλλλλλλλλλλλλλ                                   
   λλλλλλλλλλλλ      λλλλ    λλλλλ   λλλλλ    λλ  
   λλλλ  λλλλλλ      λλ λλ   λλ      λλ λλ    λλ  
  λλλλ    λλλλλλ     λλλλλ   λλλλλ   λλλλλ    λλ  
 λλλλ      λλλλλ     λλ λλ   λλ      λλλλλ    λλ  
λλλλ        λλλλ     λλ λλ   λλλλλ   λλ       λλλλ

Here you can see a comparison:

Before:

Before

After:

After

Some design/code notes:

  1. I used only λ in the drawing to match the funcional identity of the project.
  2. I used the magenta color from chalk to match randa's visual identity.
  3. I wouldn't attach the greeting.js file to the package - and then keep the greeting code in the index.js - but I thought it'd make more sense to keep the code modular and them just require the greeting.js file in the index.js.

Hope you like it :smile:

BTW, pretty interesting project!

hemanth commented 8 years ago

Awesome stuff, thanks! @mabrasil

ythecombinator commented 8 years ago

thanx :smile_cat:

hemanth commented 8 years ago

@mabrasil Will redo the gif and release the new version.

hemanth commented 8 years ago

@mabrasil Does this look ok? (it doesn't look as good as...)

screen shot 2016-01-19 at 12 37 09 pm

ythecombinator commented 8 years ago

At the moment, I had only a cmder example to attach in my PR and, yeah, maybe in your terminal - iTerm2, right? - it looks a bit different. But it' almost the very same greeting :smile:

Maybe you don't like the cyan shade from Chalk but it's the the one which most matches with ramda's - which is something like #693476 - since Chalk is aware of working on all terminals and systems and doesn't support other colors than the base eight ones. For a more accurate shade, ansi-256-colors could be used, but it wouldn't be a good idea in terms of compatibility cross terminals/systems.

Maybe you don't like the λ-based drawing, but I think it good to keep the funcional identity of the project. Also, a multi-character-based one wouldn't be so cool, e.g.

 .ohddho.                                         
:Ny///yNN/                                        
yd .+shNNNhy+`                                    
.yo/+-hNmNNNNm.                                   
   ``dN+.mNyNNo      +++/    .+//.   `o/+:    :.  
   .dN/  .mNNNd      d` h.   -y      `d `d    s:  
  -mN:    -mNNN-     d++d`   -d//`   `m`.d    s:  
 -mm-      -NNyo     d` h.   -y      `m::.    s:  
-dd-        :dhs     h` s.   -h//.   `h       oo/:

Don't you think so @hemanth?

hemanth commented 8 years ago

λ-based drawing looks fine.

I used solarized theme for terminal.

I am ok with the color, but the R and P doesn't look evident.

ythecombinator commented 8 years ago

Hey, I thought about an approach based on a Aaargh-alike font to make both R and P more clear:

 λλλλλλλλ                                                             
λλλλλλλλλλ                                                            
λλλλλλλλλλλλλλ                                                        
  λλλλλλλλλλλλλ     λλλλλλλ        λλλλλλλ       λλλλλλλ        λλ    
   λλλλ  λλλλλλλ    λλ   λλ        λλ            λλ    λ        λλ    
  λλλλ    λλλλλλ    λλλλλλλ        λλλλλλλ       λλλλλλλ        λλ    
 λλλλ      λλλλλ    λλ  λλλ        λλ            λλ             λλ    
λλλλ        λλλλ    λλ   λλλ       λλλλλλλ       λλ             λλλλλλ

and it goes like this in the terminal:

new one

What do you think @hemanth?

hemanth commented 8 years ago

Sorry, if I am too specific here, should there be space between λ and R?

ythecombinator commented 8 years ago

I don't know if I got what you mean @hemanth, but you say something like this:

 λλλλλλλλ                                                             
λλλλλλλλλλ                                                            
λλλλλλλλλλλλλλ                                                        
  λλλλλλλλλλλλλ               λλλλλλλ        λλλλλλλ       λλλλλλλ        λλ    
   λλλλ  λλλλλλλ              λλ   λλ        λλ            λλ    λ        λλ    
  λλλλ    λλλλλλ              λλλλλλλ        λλλλλλλ       λλλλλλλ        λλ    
 λλλλ      λλλλλ              λλ  λλλ        λλ            λλ             λλ    
λλλλ        λλλλ              λλ   λλλ       λλλλλλλ       λλ             λλλλλλ

where ramda's logo and the R from REPL are more spaced?

hemanth commented 8 years ago

What I meant was: The spaces between R E P L and the space between Ramda Logo and R must be the same.

ythecombinator commented 8 years ago

Oh, sorry, now I see.

How about this:

 λλλλλλλλ                                                             
λλλλλλλλλλ                                                            
λλλλλλλλλλλλλλ                                                        
  λλλλλλλλλλλλλ         λλλλλλλ         λλλλλλλ        λλλλλλλ        λλ    
   λλλλ  λλλλλλλ        λλ   λλ         λλ             λλ    λ        λλ    
  λλλλ    λλλλλλ        λλλλλλλ         λλλλλλλ        λλλλλλλ        λλ    
 λλλλ      λλλλλ        λλ  λλλ         λλ             λλ             λλ    
λλλλ        λλλλ        λλ   λλλ        λλλλλλλ        λλ             λλλλλλ

Exactly 8 whitespaces between each right edge of a character and the following left edge.

What do you think?

ythecombinator commented 8 years ago

Any feedback @hemanth?

hemanth commented 8 years ago

Sorry, I had missed this, looks great now :+1:

ythecombinator commented 8 years ago

I'll updte the code and then send a new PR in a few minutes :smile:

ythecombinator commented 8 years ago

Done here #9