hemberg-lab / scmap

A tool for unsupervised projection of single cell RNA-seq data
http://bioconductor.org/packages/scmap
GNU General Public License v3.0
90 stars 11 forks source link

Add 'codetools' to Suggests: #40

Open HenrikBengtsson opened 1 year ago

HenrikBengtsson commented 1 year ago

Hello,

your package vignette relies indirectly(*) on the codetools package, which is a package that is not guaranteed to be installed on all systems; it's only a recommended package. Because of this, R CMD check on you package fails on such systems (see below).

(*) Searching the code of your package for codetools gives zero hits, which suggests that it codetools is used by another package that your package depends on, but only as a soft dependency. Because of this, you need to declare codetools as a dependency in your package.

To fix this, please add codetools to Suggests:, i.e.

Suggests: knitr,
    rmarkdown,
    codetools

Example what happens when codetools is not installed:

* using R version 4.3.1 (2023-06-16)
* using platform: x86_64-pc-linux-gnu (64-bit)
...* checking re-building of vignette outputs ... ERROR
Error(s) in re-building vignettes:
  ...
  --- re-building ‘scmap.Rmd’ using rmarkdown
  Quitting from lines 15-17 [knitr-options] (scmap.Rmd)
  Error: processing vignette 'scmap.Rmd' failed with diagnostics:
  there is no package called 'codetools'
  --- failed re-building ‘scmap.Rmd’    
  SUMMARY: processing the following file failed:
  ‘scmap.Rmd’

Error: Vignette re-building failed.
Execution halted