search

hemelb-codes / hemelb

A high performance parallel lattice-Boltzmann code for large scale fluid flow in complex geometries
GNU Lesser General Public License v3.0
34 stars 11 forks source link

Consider removing recovery layer (reset functionality) from code. #222

Closed schmie closed 9 years ago

schmie commented 9 years ago

Reported by jamespjh on 26 Mar 2012 15:19 UTC The reset functionality is poorly tested and not well used.

For supercomputers, we (JH+HC) think that this recover-and-change-timestep functionality is a liability.

We could remove the recovery layer altogether, and have a recovery layer either in the main function or in python.

schmie commented 9 years ago

Modified by jamespjh on 12 Apr 2012 09:00 UTC

schmie commented 9 years ago

Modified by jamespjh on 12 Apr 2012 13:07 UTC

schmie commented 9 years ago

Modified by jamespjh on 26 Apr 2012 12:39 UTC

schmie commented 9 years ago

Modified by jamespjh on 26 Apr 2012 13:39 UTC

schmie commented 9 years ago

Modified by jamespjh on 22 Jun 2012 12:17 UTC

schmie commented 9 years ago

Modified by jamespjh on 22 Jun 2012 12:23 UTC

schmie commented 9 years ago

Modified by jamespjh on 2 Jul 2012 13:16 UTC

schmie commented 9 years ago

Modified by jamespjh on 5 Jul 2012 13:14 UTC

schmie commented 9 years ago

Modified by jamespjh on 5 Jul 2012 15:34 UTC

schmie commented 9 years ago

Modified by jamespjh on 5 Jul 2012 16:13 UTC

schmie commented 9 years ago

Modified by jamespjh on 26 Jul 2012 15:12 UTC

schmie commented 9 years ago

Comment by jamespjh on 26 Jul 2012 15:26 UTC comparing with ssh://hg@entropy.chem.ucl.ac.uk/hemelb searching for changes changeset: 2343:58af7c2a2856 user: James Hetherington j.hetherington@ucl.ac.uk date: Thu Jul 26 16:16:39 2012 +0100 summary: #244, abort not reset on unstable

changeset: 2344:46f6c39b7b6e tag: tip user: James Hetherington j.hetherington@ucl.ac.uk date: Thu Jul 26 16:28:40 2012 +0100 summary: #244 Remove unused reset functionality

schmie commented 9 years ago

Modified by jamespjh on 26 Jul 2012 16:08 UTC

schmie commented 9 years ago

Modified by jamespjh on 26 Jul 2012 16:08 UTC

schmie commented 9 years ago

Comment by hywel on 29 Jul 2012 16:46 UTC So pleased to see this code go...

Can we rename Reset in the !SteeringComponent? I think its name is misleading.

All the LB collisions / kernels / streamers have a Reset function which I assume is now unused and should probably be removed. Sorry about that...

SimulationMaster::!ResetUnstableSimulation has a misleading name now. Perhaps it should be !OnUnstableSimulation.

Cheers

schmie commented 9 years ago

Modified by hywel on 3 Aug 2012 11:14 UTC

schmie commented 9 years ago

Comment by jamespjh on 13 Aug 2012 13:09 UTC cfe26f94f37c

schmie commented 9 years ago

Modified by jamespjh on 13 Aug 2012 13:09 UTC

schmie commented 9 years ago

Comment by hywel on 13 Aug 2012 21:34 UTC Looks good to me, cheers.

schmie commented 9 years ago

Modified by jamespjh on 14 Aug 2012 10:15 UTC