Some setup tool usability issues

[mobernabeu]

Over the past few months, I've collected a list of small setup tool usability issues:

• [x] The Save Profile dialog tries to save as .pro although the files are written in the new .pr2 file format.
• [x] The .pr2 file writer seems to be pickling the iolet property Radiusrather than writing it as plain text.
• [ ] The GUI doesn't allow the user to specify simulation duration or time step. This has to be done directly on the XML file after the geometry has been generated.
• [x] Iolet planes disappear when their radius text box is left empty and they won't reappear if a valid value is added.
• [ ] It would help non-power users if the setup tool generated XML files with some basic simulation output configuration. At the moment, the default is no output at all and the user has to specify what he/she wants directly on the generated XML file.
• [ ] Idem for the XML element that turns on steady state simulation convergence monitoring.

[rupertnash]

First done in 29cbbcb

[rupertnash]

@mobernabeu I can't reproduce the second error about pickling iolet radius. Can you please let me know how to trigger it?

[rupertnash]

number 3 tackled in branch bugfix/setuptool-zero-radius

Please have a look and merge if it works for you.

[mobernabeu]

@rupertnash, I only experience the pickling problem in the case of outlets (see below). Can you reproduce this?

Iolets:
- Centre: {x: 450.3373067934434, y: 1475.295948325393, z: 0.0}
  Name: Inlet1
  Normal: {x: 0.288169929424619, y: -0.9447486847084856, z: 0.0}
  Pressure: {x: 80.0, y: 0.0, z: 0.0}
  Radius: 7.7
  Type: Inlet
- Centre: {x: 633.7661162954839, y: 1476.9415681076712, z: 0.0}
  Name: Inlet2
  Normal: {x: 0.5627290033062073, y: -0.8266414391004135, z: 0.0}
  Pressure: {x: 80.0, y: 0.0, z: 0.0}
  Radius: 4.7
  Type: Inlet
- Centre: {x: 290.9860591903817, y: 1475.2952716713407, z: 0.0}
  Name: Outlet1
  Normal: {x: -0.034219671564852575, y: -0.9994143355375654, z: 0.0}
  Pressure: {x: 80.0, y: 0.0, z: 0.0}
  Radius: !!python/object/apply:numpy.core.multiarray.scalar
  - !!python/object/apply:numpy.dtype
    args: [f8, 0, 1]
    state: !!python/tuple [3, <, null, null, null, -1, -1, 0]
  - !!binary |
    SZqZmZmZJkA=
  Type: Outlet

[mobernabeu]

number 3 tackled in branch bugfix/setuptool-zero-radius

@rupertnash, I'm assuming you meant number 4 here? Could you please open a PR for me to check?

[mobernabeu]

I'm getting confused now. The latest profile file I generated has a mix of human readable and not.

Iolets:
- Centre: {x: 32.852845659059525, y: 210.14746625560412, z: 0.0}
  Name: Outlet1
  Normal: {x: 1.0, y: -0.0, z: 0.0}
  Pressure: {x: 0.0, y: 0.0, z: 0.0}
  Radius: 20.0
  Type: Outlet
- Centre: {x: 66.8869854247383, y: 131.73231814568922, z: 0.0}
  Name: Outlet2
  Normal: {x: 0.7223793943652844, y: 0.6914969346254869, z: 9.992007221626383e-16}
  Pressure: {x: 0.0, y: 0.0, z: 0.0}
  Radius: !!python/object/apply:numpy.core.multiarray.scalar
  - !!python/object/apply:numpy.dtype
    args: [f8, 0, 1]
    state: !!python/tuple [3, <, null, null, null, -1, -1, 0]
  - !!binary |
    9///////L0A=
  Type: Outlet
- Centre: {x: 119.69254688838691, y: 83.48171808301694, z: 0.0}
  Name: Outlet3
  Normal: {x: 0.15340876662281588, y: 0.9868423982913032, z: 0.0}
  Pressure: {x: 0.0, y: 0.0, z: 0.0}
  Radius: 9.1
  Type: Outlet
- Centre: {x: 201.50104288130854, y: 123.63532836375435, z: 0.0}
  Name: Outlet4
  Normal: {x: -0.7428953450143764, y: 0.6694075786514303, z: 0.0}
  Pressure: {x: 0.0, y: 0.0, z: 0.0}
  Radius: !!python/object/apply:numpy.core.multiarray.scalar
  - !!python/object/apply:numpy.dtype
    args: [f8, 0, 1]
    state: !!python/tuple [3, <, null, null, null, -1, -1, 0]
  - !!binary |
    SzMzMzOzN0A=
  Type: Outlet
- Centre: {x: 208.65031319067333, y: 214.58458692665124, z: 0.0}
  Name: Inlet1
  Normal: {x: -0.8150265516381408, y: -0.5793063421933716, z: 0.0}
  Pressure: {x: 0.01, y: 0.0, z: 0.0}
  Radius: !!python/object/apply:numpy.core.multiarray.scalar
  - !!python/object/apply:numpy.dtype
    args: [f8, 0, 1]
    state: !!python/tuple [3, <, null, null, null, -1, -1, 0]
  - !!binary |
    GgAAAACAPEA=
  Type: Inlet
- Centre: {x: 167.16768128078962, y: 293.60747388162474, z: 0.0}
  Name: Inlet2
  Normal: {x: -0.884343, y: -0.466837, z: 0.0}
  Pressure: {x: 0.01, y: 0.0, z: 0.0}
  Radius: 10.0
  Type: Inlet
- Centre: {x: 107.86287588384133, y: 296.5240975225619, z: 0.230154071615285}
  Name: Inlet3
  Normal: {x: 0.6610766359932245, y: -0.7503183866492156, z: 7.757966604727624e-15}
  Pressure: {x: 0.01, y: 0.0, z: 0.0}
  Radius: !!python/object/apply:numpy.core.multiarray.scalar
  - !!python/object/apply:numpy.dtype
    args: [f8, 0, 1]
    state: !!python/tuple [3, <, null, null, null, -1, -1, 0]
  - "\x11\0\0\0\0\0<@"
  Type: Inlet

[mobernabeu]

Second item dealt with in #641