search

hemelb-codes / hemelb

A high performance parallel lattice-Boltzmann code for large scale fluid flow in complex geometries
GNU Lesser General Public License v3.0
34 stars 11 forks source link

Validate consistent RBC configuration in XML file #691

Open mobernabeu opened 7 years ago

mobernabeu commented 7 years ago

We wasted some ARCHER time with a channel simulation that defined the <flowextension> XML element for the inlet but not for the outlet. In this scenario, RBCs are not removed when they reach the end of the computational domain and all kind of things can go wrong.

<flowextension> needs to be kept optional in the inlet/outlet XML definition in case the user wants to run homogeneous fluid simulations (Newtonian or generalised-Newtonian). However, if the <redbloodcells> element is defined we should error if the user didn't provide a <flowextension> definition for all inlets/outlets.

rupertnash commented 3 years ago

Is this solved by 16e659766ab2b07919cf5cb4ca161d21558afe6f?