search

hemelb-codes / hemelb

A high performance parallel lattice-Boltzmann code for large scale fluid flow in complex geometries
GNU Lesser General Public License v3.0
34 stars 11 forks source link

RBC inserter initialisation is not reproducable #755

Open rupertnash opened 3 years ago

rupertnash commented 3 years ago

In the course of making a wee XML checker, I see that that readSingleRBCInserter in redblood/io.cc uses the time to initialise the PRNGs

It would be much better to add the seed required to the input file. This will also remove the need to use MPI here.

rupertnash commented 1 year ago

This is partially fixed in SimConfig::DoIOForBaseInOutlet, although the old behaviour continues if omitted