search

hemerajs / hapi-hemera

Hapi plugin to integrate Hemera.
MIT License
16 stars 7 forks source link

Collision with seneca #3

Closed sberryman closed 7 years ago

sberryman commented 7 years ago

I'm currently using seneca and would like to try out hemera from the same hapi server (for a few routes) but I'm running into an issue with decorations as seneca is already defining them (via Chairo)

(node:9810) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Server decoration already defined: action

What do you think about extending internals.defaults with an option to disable hapi decorations. Obviously this would be disabled/false by default.

Then we can check the options before decorating hapi. I'll do a quick PR if you think this makes sense for the general hemera community.

StarpTech commented 7 years ago

PR was closed due to inactivity and issue was fixed with https://github.com/hemerajs/hapi-hemera/pull/6