Closed joshuasing closed 1 month ago
@joshuasing as long as this passes this is an approval from me ✅ https://github.com/hemilabs/heminetwork/actions/runs/10496216883
Reverted to Go 1.22.6 in e2e/optimism-stack.dockerfile
due to an incompatibility between a module used by go-ethereum and Go 1.23 (github.com/fjl/memsize
). Once we rebase https://github.com/hemilabs/op-geth, we should update this to Go 1.23.
https://github.com/fjl/memsize/issues/4 https://github.com/ethereum/go-ethereum/issues/30100 https://github.com/ethereum/go-ethereum/pull/30253 https://github.com/ethereum-optimism/op-geth/commit/04354cf987b0a9429b3f9262c2dd7f7dc95ad935
Summary Build project with Go v1.23. This does not change the
go
directive in thego.mod
files, meaning we do not require consumers of this module to usego1.23
, and we cannot use Go v1.23 features yet.Changes
go1.23
1.23.x
in GitHub Actions1.23-alpine3.20
and1.23-bookworm
(debian)Note: Go v1.23 introduces new
go vet
checks for theslices
package which are currently failing, resolved by #215