Summary
Fix ElectrumX connection pool open/closed/idle metrics.
Previously, the open metric and closed_total metrics weren't handled properly when a connection is closed.
They would only be changed if the connection was also removed from the connection pool, which is false in most cases.
Additionally, the connsIdle metric needs to be decremented when a connection in the pool is removed and closed.
Changes
Decrement connsIdle if a connection is removed from the pool in onClose.
Always decrement connsOpen when a connection is closed.
Always increment connsClosed when a connection is closed.
Summary Fix ElectrumX connection pool open/closed/idle metrics.
Previously, the
openmetric andclosed_totalmetrics weren't handled properly when a connection is closed. They would only be changed if the connection was also removed from the connection pool, which is false in most cases.Additionally, the
connsIdlemetric needs to be decremented when a connection in the pool is removed and closed.Changes