hemker / apkgrabber

APKGrabber is a tool that simplifies the process of finding updates for your installed apps.
GNU General Public License v3.0
425 stars 23 forks source link

Checking for updates while in on android P causes phone to vibrate wildly / set off a lot of notification alerts #25

Closed pagzamaphone closed 5 years ago

pagzamaphone commented 5 years ago

Running on Android P with March security updates on an Essential PH-1

It appears the priority for the notifications to update the count of the progress bar is set too high, which causes the phone to vibrate/alert once per every time the loading bar moves, so when its checking ~400 apks, it may do a lot.

Coming from APKUpdator this is different, and i'm assuming unintended behaviour.

Let me know if more repro steps are needed.

TPS commented 5 years ago

This can be worked around by disabling vibration for just that notification (Android System Settings → Apps & Notifications → APKGrabber → App Notifications → {Pick whichever category} → Vibrate), while @hemker works on the fix.

Kaz1993 commented 5 years ago

I think this line in the NotificationHelper is causing the issue

channel.setVibrationPattern(new long[]{100, 200, 300, 400, 500, 400, 300, 200, 400});

Maybing adding "100" is good enough.

hemker commented 5 years ago

@pagzamaphone should be fixed in current release. Please confirm.

pagzamaphone commented 5 years ago

At first i didn't think it did resolved the issue, because all i did was upgrade from the previous version to this version, however after clearing my storage for the app it appears to have resolve the issue.

I dunno if you need to clear the database or something between versions to make sure that new notification helper setting take effect, but it works now, so i'm finally going to switch over to using it and uninstall apkupdater :)

hemker commented 5 years ago

@pagzamaphone settings like notification channel vibration patterns are persistent between app versions, so after the pattern is fixed now, an unique cleaning of your app data (as you already did and explained) will fix the problem.