search

henadzit / grails-browser-detection

https://grails.org/plugin/browser-detection
Apache License 2.0
11 stars 11 forks source link

Windows Mobile is not detected #11

Open mathifonseca opened 10 years ago

mathifonseca commented 10 years ago

I'm testing with a Nokia Lumia 625 and it doesn't detect that it is mobile. I've attached a screenshot with some of the method's results. 20140818_111431

pbujko commented 10 years ago

Hi guys, any update on this one?

looking forward for fix (Lumia 820 here)

mathifonseca commented 10 years ago

I fixed it, made a pull request and @sbglasius merged it, but the plugin in Grails portal is not yet updated :(

pbujko commented 10 years ago

I had same situation with publishing other plugin. portal was not updated but new binaries were available from repo. would the new version be def version = "1.0.1" ?

mathifonseca commented 10 years ago

I think only the owner of the plugin in Grails portal can publish a new version of the plugin. I didn't try with this one. I'm currently using it as a local plugin while I wait for the new version in the portal.

henadzit commented 10 years ago

Hey guys, sorry I don't support this plugin anymore.

The plugins portal is very lame, it doesn't have a permission concept as far as I remember. I think, anybody who has an account may create or update plugins. They have a page describing the process which could be a bit tricky.

Thanks, Henadzi

mathifonseca commented 10 years ago

Thanks Henadzi!

I'll try to publish the modified version and let you know what happens.

In case I can't and assuming you don't want to support this plugin anymore in the future, I'd like to contact the Grails team to pass over the control of the plugin to me if you agree.

Regards, Mathias On Sep 10, 2014 7:14 PM, "henadzit" notifications@github.com wrote:

Hey guys, sorry I don't support this plugin anymore.

The plugins portal is very lame, it doesn't have a permission concept as far as I remember. I think, anybody who has an account may create or update plugins. They have a page describing the process which could be a bit tricky.

Thanks, Henadzi

— Reply to this email directly or view it on GitHub https://github.com/henadzit/grails-browser-detection/issues/11#issuecomment-55191377 .

mathifonseca commented 10 years ago

Tried to publish the plugin with my credentials but it says "Permission denied".

@henadzit, do you want me to contact the Grails team to transfer the permission?

henadzit commented 10 years ago

Yeah, go ahead! Honestly, I don't remember what kind of permissions they have if they have at all.