search

henadzit / grails-browser-detection

https://grails.org/plugin/browser-detection
Apache License 2.0
11 stars 11 forks source link

add handling for empty user-agent-browser-versions #13

Closed robbyengelhardt closed 8 years ago

robbyengelhardt commented 8 years ago

We have found in our web-site-logs (www.dastelefonbuch.de) that some browsers came without any version inside the user-agent-string. This forces a HTTP500 on our server because this case ist not handled in your plugin.

We use 

<browser:choice>
    <browser:isChrome versionGreater="50"></browser:isChrome>
    <browser:otherwise>render some stuff for chrome greater 50</browser:otherwise>
</browser:choice>

The user-agent we found was Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/ Safari/537.36

We would suggest to handle this case like an "otherwise" case.

henadzit commented 8 years ago

Hi,

The plugin at https://grails.org/plugin/browser-detection is built from https://github.com/mathifonseca/grails-browser-detection. I do not support this project anymore.

Thanks, Henadzi

robbyengelhardt commented 8 years ago

Hi Henadzi Tsaryk,

sorry for the confusion. There was a problem with the github and new pull requests were routed to your old version of the project. Thanks for the information. I contacted the current maintainer and we found a solution for our problem leeding to a new version of the plugin. And he "repaired" the github-page.

Mit freundlichen Grüßen/With kind regards

Robby Engelhardt Teamleiter Verzeichnislösungen – TB/ÖTB

Tel. +49 911 30 730-0 Fax +49 911 30 730-111 robby.engelhardt@it2media.de mailto:robby.engelhardt@it2media.de www.it2media.de http://www.it2media.de/

IT2media GmbH & Co. KG, Pretzfelder Str. 13, 90425 Nürnberg · Kommanditgesellschaft Sitz Nürnberg, Amtsgericht Nürnberg HRA 12784 · Persönlich haftende Gesellschafterin: IT2media Beteiligungsgesellschaft mbH, Sitz Nürnberg, Amtsgericht Nürnberg HRB 19511 ·

Geschäftsführer: Oliver Neuerbourg, Mathias Pauli

Diese E-Mail wurde umweltverträglich aus recycelten Bits erstellt

Am 16.08.2016 um 13:08 schrieb Henadzi Tsaryk:

Hi,

The plugin at https://grails.org/plugin/browser-detection is built from https://github.com/mathifonseca/grails-browser-detection. I do not support this project anymore.

Thanks, Henadzi

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/henadzit/grails-browser-detection/pull/13#issuecomment-240072496, or mute the thread https://github.com/notifications/unsubscribe-auth/AUFP1wi4zydxMTgRs0ELItwJ4WmahwYuks5qgZo3gaJpZM4JlQ2D.

henadzit commented 8 years ago

No problem! I'm glad it sorted out.