Peer To Peer Code Review Week 1 Module 2

[Diegogagan2587]

Peer To Peer Code Review Week 1 Module 2

implemented to @henask12 by @Diegogagan2587 and @ITurres

[Diegogagan2587]

Hi @henask12

Good job so far!💪

The following comments are the Group's peer-to-peer code review suggestions...

Team Suggested Changes ♻️:

By @dieg:

• [ ] Would be great if posible for you to fix the display error as you can see in the IMG:

consider using flexbox for the main section, so you can add flex-direction rows or columns depending on what version are you wokring, if deskctop or mobile.

[Diegogagan2587]

Hi @henask12

Good job so far!💪

The following comments are the Group's peer-to-peer code review suggestions...

Team Suggested Changes ♻️:

By @ITurres:

Hi @henask12! :D, you project looks very like the design provided, great job!💪

Nevertheless, I can suggest the following;

• [GitHub-flow] It is considered a good practice for the commits to match the changes made as well as committing for small chunk of changes. e.g. most of the commits on this branch aren't descriptive enough, say commit #969897a with the message small fix > the changes made on that commit was a total Deletion of the whole code/file, therefore it will difficult to debug in the future.

I leave below a very helpful link on the subject :D Git Commit Best Practices](https://gist.github.com/luismts/495d982e8c5b1a0ced4a57cf3d93cf60)

• [workflow] You could make use of a code formatter such as Prettier or the like to enforce a consistent code style in all HTML, CSS, js, etc. And make it more appealing to the eye as well as organized, e,g. by removing all unnecessary empty lines, applying a good indentation hierarchy and the like.

• [liveDemo] Kindly check your database-like to modify your src path on the 'Feature speakers' section, because on the deployed version it is not loading every Speaker img.

---

[ITurres]

GRAMMARLY CHANGES

Hi @henask12

Good job so far!💪

The following comments are the Group's peer-to-peer code review suggestions...

Team Suggested Changes ♻️:

By @ITurres:

Hi @henask12! :D, your project looks very like the design provided, great job!💪

Nevertheless, I can suggest the following;

• [GitHub-flow] It is considered good practice for the commits to match the changes made as well as committing for a small chunk of changes. e.g. most of the commits on this branch aren't descriptive enough, say commit #969897a with the message small fix > the changes made on that commit was a total Deletion of the whole code/file, therefore it will difficult to debug in the future.

• I leave below a very helpful link on the subject :D Git Commit Best Practices

• [workflow] You could make use of a code Formatter such as Prettier or the like to enforce a consistent code style in all HTML, CSS, js, etc. And make it more appealing to the eye as well as organized, e,g. by removing all unnecessary empty lines, applying a good indentation hierarchy, and the like.

• [liveDemo] Kindly check your database-like to modify your src path on the 'Feature speakers' section, because on the deployed version it is not loading every Speaker img.