henbagle / LE1CommunityPatch

Issue tracker for the Community Patch mod for Mass Effect 1: Legendary Edition
13 stars 0 forks source link

Feros: Conversation lights remain on for ambient final conversation lines #112

Closed henbagle closed 2 years ago

henbagle commented 2 years ago

File: BIOA_WAR20_03f_DSG.pcc, BIOA_WAR20_03f_DSG_LOC_INT.pcc, BIOA_WAR40_06_DSG.pcc, BIOA_WAR40_06_DSG_LOC_INT.pcc

Needs fixed in localized file? Yes, done

Description of fix: Conversations on Feros with Fai Dan, Arcelia Silva Martinez, Julianna Baynham, Ethan Jeong, and Gavin Hossle typically start as full conversations, but the last line will be an ambient. The conversation lighting is left on for this ambient, causing an odd moment where the lights turn off instantly after the conversation is over. This is distracting and noticeable. I have fixed these conversations so the lights turn off during the transition from full conversation to ambient instead.

In each conversation's sequence in the DSG file, a Conversation event is added to trigger at the start of any dialogue node with a "LightsOff" script. This event is sequenced to turn off the conversation lighting. One of these is needed for each conversation.

image

Any final ambient lines in each conversation has the "LightsOff" script added to it to trigger this event. Dialogue nodes modified are listed below. war20_arceliasilvamartinez_dlg: E19, E20 war20_faizhou_dlg: E63 war40_gunman_dlg: E2, E3, E7, E17 war40_heajeong_dlg: E25, E56 war40_juliannabaynham_dlg: E64