search

henbagle / LE1CommunityPatch

Issue tracker for the Community Patch mod for Mass Effect 1: Legendary Edition
13 stars 0 forks source link

The BioSubtitles class does not respect the selected subtitle size #133

Open AudemusN7 opened 2 years ago

AudemusN7 commented 2 years ago

Describe the bug This needs a more thorough investigation to confirm, but I believe that in instances where the BioSubtitles class is used, the global subtitle size selected in LE Launcher is not applying correctly.

To Reproduce

  1. Set subtitle size to Small in LE Launcher
  2. Go to BIOA_UNC52 (This is the quickest way to get to an affected area, but not the only place it occurs)
  3. Observe subtitle size during intro cinematic
  4. Change subtitle size to Large in LE Launcher and repeat previous steps

Expected behavior The subtitle size should match conversation & ambient subtitle sizes.

Other Considerations I considered that this may be intentional since these subtitles tend to play on top of FMVs, however since this class isn't used during the Citadel arrival cinematic, I'm inclined to think this is just an oversight.

Game file The BioSubtitles class is used in the following files:

BIOA_END20_Bridge_CIN BIOA_END70C_Bridge_CIN BIOA_END70D_Bridge_CIN BIOA_LOS0_Bridge_CIN BIOA_UNC52

henbagle commented 2 years ago

Issue partially fixed in BDtS as laid out in #84. Unfortunately the fix only affects normal conversation subtitles, the bug remains for all subtitles playing on top of FMVs, including FMVs in BDtS.