search

henbagle / LE1CommunityPatch

Issue tracker for the Community Patch mod for Mass Effect 1: Legendary Edition
13 stars 0 forks source link

Various mercenaries and pirates have a partially pink and white helmet #15

Closed henbagle closed 3 years ago

henbagle commented 3 years ago

Describe the bug ERCS Guard on Noveria (in the synthetic insights lab fight) has a partially pink and white helmet, bug also reported on various mercenaries and pirates

Screenshots & Saves TMjP5Q6 - Tydeous RiygHEs - Tydeous

henbagle commented 3 years ago

Other instances: Cerberus Snipers on Nepheron, Alliance Soldier from UNC: Listening Post Alpha on Nepmos

henbagle commented 3 years ago

The mesh in question is HMM_BTR_HVY_MDL, may be misspelled as HMM_BRT_HVY_MDL in some contexts. The visors have a tint map, and inappropriate colors appear to be applied to it. The issue is in the MaterialInstanceConstant in each file that uses this mesh. Changing the HGR_Colour_01 (white part of visor) and HGR_Colour_02 (Pink/red part of visor) in the VectorParameterValues array to more appropriate colors fixes the issue.

For example, Export 9802 in file BIOA_ICE20_06_DSG.pcc is the affected export for the two mercenaries in the Synthetic Insights office (can be fought after getting the data from Lorik Qui'in's computer)

Finding all usages of this visor and fixing the tints will be the fix for this bug.

henbagle commented 3 years ago

Non-exhaustive list of files where this is an issue: BIOA_ICE20_06_DSG.pcc BIOA_UNC10_01_DSG.pcc BIOA_UNC10_02_DSG.pcc BIOA_UNC11_01_DSG.pcc BIOA_UNC11_02_DSG.pcc BIOA_UNC13_02_DSG.pcc BIOA_UNC20_00_DSG.pcc BIOA_UNC30_00_DSG.pcc BIOA_UNC31_02_DSG.pcc BIOA_UNC42_00_DSG.pcc BIOA_UNC42_02_DSG.pcc BIOA_UNC52_00_DSG.pcc BIOA_UNC52_00survey_DSG.pcc BIOA_UNC52_00torch_DSG.pcc BIOA_UNC53_00_DSG.pcc BIOA_UNC54_00_DSG.pcc BIOA_UNC61_02_DSG.pcc BIOA_UNC62_01_DSG.pcc BIOA_UNC62_02_DSG.pcc BIOA_UNC73_01_DSG.pcc BIOA_UNC80_02_DSG.pcc BIOA_UNC82_01_DSG.pcc BIOA_UNC82_02_DSG.pcc BIOA_UNC90_01_DSG.pcc BIOA_UNC90_02_DSG.pcc BIOA_UNC92_01_DSG.pcc BIOA_UNC92_02_DSG.pcc

henbagle commented 3 years ago

Fixed via the method listed above, changing the HGR_Colour_01 and 02 of each MaterialInstanceConstant in the affected files. The HGR_Colour_01 was changed to match the armor color of the wearer. Where necessary, the MaterialInstanceConstant was cloned so two different colors could be used, and the Materials property was added to the usage of the visor to specify an instance.

Some pink visors may have been missed, if you discover any that have not been fixed please drop me a line.

henbagle commented 3 years ago

Hex colors for HGR_Colour_01 of each armor grey/corp sec: #FF212329 green/cerberus: #FF060A05 cream/mercenary 02: #FF998755 black/mercenary 01: #FF0A0D0F jungle camo: #FF0A0A05 mercenary 02 MED black: #FF121517

henbagle commented 1 year ago

Bugfix has now been properly applied in BIOA_UNC11_02_DSG.pcc