Shepard's "GO!" subtitle appears during sovereign's destruction even with subtitles off

henbagle / LE1CommunityPatch

Issue tracker for the Community Patch mod for Mass Effect 1: Legendary Edition

13 stars 0 forks source link

Shepard's "GO!" subtitle appears during sovereign's destruction even with subtitles off #61

Closed henbagle closed 3 years ago

henbagle commented 3 years ago

Describe the bug This is the same issue as #10, where the line overlaps with the start of a .bik, causing the subtitle to be shown briefly over the bik.

Solution: New sequence object used to check whether subtitles are off, and switch to a FaceOnlyVO with subtitles forced off if they should not be showing.

Game file BIOA_END70_02E_CIN.pcc

henbagle commented 3 years ago

New and improved fix for both this issue and #10

New sequence object added to LEX - SFXSeqAct_GetGameOption is used to get the integer value of the subtitle setting (setting type 5 in the enum). The value of this setting is used to choose a FaceOnlyVO line to play. If subtitles are off, it plays a FaceOnlyVO with m_bForceHideSubtitles set to true. If subtitles are on, it plays the FaceOnlyVO line as usual.