henbagle / LE1CommunityPatch

Issue tracker for the Community Patch mod for Mass Effect 1: Legendary Edition
13 stars 0 forks source link

Object Streaming Compendium #82

Open Herobrine24 opened 2 years ago

Herobrine24 commented 2 years ago

1. Screenshot 2021-09-17 210430

Screenshot 2021-09-17 210702

2. Screenshot 2021-09-17 210956

Screenshot 2021-09-17 211001

I've noticed several instances of fog volumes popping in and out across levels, like seen here in the second circle from the left.

3. Screenshot 2021-09-17 211249

Screenshot 2021-09-17 211415

4. Screenshot 2021-09-17 211249

Screenshot 2021-09-17 211415

5. Screenshot 2021-09-17 211658

Screenshot 2021-09-17 211854

6. Screenshot 2021-09-17 211849

Screenshot 2021-09-17 211915

7. Screenshot 2021-09-17 212031

Screenshot 2021-09-17 212035

8. Screenshot 2021-09-17 212202

Screenshot 2021-09-17 212205

9. Screenshot 2021-09-17 212437

Screenshot 2021-09-17 212454

10. Screenshot 2021-09-17 212614

Screenshot 2021-09-17 212618

11. Screenshot 2021-09-17 212719

Screenshot 2021-09-17 213356

12. Screenshot 2021-09-17 213437

Screenshot 2021-09-17 213440

13. Screenshot 2021-09-17 213926

Screenshot 2021-09-17 213930

14. Screenshot 2021-09-17 214653

Screenshot 2021-09-17 214710

15. Screenshot 2021-09-17 214749

Screenshot 2021-09-17 214801

16. Screenshot 2021-09-18 095625

Screenshot 2021-09-18 095716

17. Screenshot 2021-09-18 102109

Screenshot 2021-09-18 102120

18. Screenshot 2021-09-18 103639

Screenshot 2021-09-18 103642

19. Screenshot 2021-09-18 104505

Screenshot 2021-09-18 104523

20. Screenshot 2021-09-18 104818

Screenshot 2021-09-18 104822

21. Screenshot 2021-09-18 105240

Screenshot 2021-09-18 105244

22. Screenshot 2021-09-18 110457

Screenshot 2021-09-18 110514

23. Screenshot 2021-09-18 115017

Screenshot 2021-09-18 115032

24. Screenshot 2021-09-18 115414

Screenshot 2021-09-18 115348

25. Screenshot 2021-09-18 115513

Screenshot 2021-09-18 115551

26. Screenshot 2021-09-18 115903

Screenshot 2021-09-18 115934

27. Screenshot 2021-09-18 120120

Screenshot 2021-09-18 120129

28. Screenshot 2021-09-18 120432

Screenshot 2021-09-18 120511

29. Screenshot 2021-09-18 135615

Screenshot 2021-09-18 135047

Screenshot 2021-09-18 135050

Screenshot 2021-09-18 135054

Screenshot 2021-09-18 135431

Screenshot 2021-09-18 142221

30. Screenshot 2021-09-18 140358

Screenshot 2021-09-18 135823

Screenshot 2021-09-18 135826

Screenshot 2021-09-18 140355

Homecoming Questgiver most likely also affected.

31. Screenshot 2021-09-18 141550

Screenshot 2021-09-18 141546

32. Screenshot 2021-09-18 141854

Screenshot 2021-09-18 141857

The C-Sec v. Preaching Hanar quest is most likely also affected

33. Screenshot 2021-09-18 142846

Screenshot 2021-09-18 142922

34. Screenshot 2021-09-18 143047

Screenshot 2021-09-18 143054

35. Screenshot 2021-09-18 143419

Screenshot 2021-09-18 143348

36. Screenshot 2021-09-18 143711

Screenshot 2021-09-18 143813

37. Screenshot 2021-09-18 144000

Screenshot 2021-09-18 143933

38. Screenshot 2021-09-18 144602

Screenshot 2021-09-18 144605

39. Screenshot 2021-09-18 144702

Screenshot 2021-09-18 144727

40. Screenshot 2021-09-18 144803

Screenshot 2021-09-18 144825

41. Screenshot 2021-09-18 144924

Screenshot 2021-09-18 144947

42. Screenshot 2021-09-18 145025

Screenshot 2021-09-18 145008

43. Screenshot 2021-09-18 145118

Screenshot 2021-09-18 145137

44. Screenshot 2021-09-18 155529

Screenshot 2021-09-18 155532

45. Screenshot 2021-09-18 155658

Screenshot 2021-09-18 155717

46. Screenshot 2021-09-18 155848

Screenshot 2021-09-18 155925

47. Screenshot 2021-09-19 104306

Screenshot 2021-09-19 104335

48. Screenshot 2021-09-19 120926

Screenshot 2021-09-19 121059

49. Screenshot 2021-09-19 120940

Screenshot 2021-09-19 121033

50. Screenshot 2021-09-19 121341

Screenshot 2021-09-19 121403

51. Screenshot 2021-09-19 121848

Screenshot 2021-09-19 121911

52. Screenshot 2021-09-19 122305

Screenshot 2021-09-19 122323

53. Screenshot 2021-09-19 122457

Screenshot 2021-09-19 122522

54. Screenshot 2021-09-19 122721

Screenshot 2021-09-19 122747

55. Screenshot 2021-09-19 122801

Screenshot 2021-09-19 122823

56. Screenshot 2021-09-19 125948

Screenshot 2021-09-19 125951

57. Screenshot 2021-09-19 130109

Screenshot 2021-09-19 130121

58. Screenshot 2021-09-19 133933

Screenshot 2021-09-19 133946

59. Screenshot 2021-09-19 134337

Screenshot 2021-09-19 134340

60. Screenshot 2021-09-19 134447

Screenshot 2021-09-19 134509

61. Screenshot 2021-09-19 141041

Screenshot 2021-09-19 141044

62. Screenshot 2021-09-19 141226

Screenshot 2021-09-19 141302

63. Screenshot 2021-09-19 141900

Screenshot 2021-09-19 141925

64. Screenshot 2021-09-19 142201

Screenshot 2021-09-19 142203

The floating debree above is also affected.

ShredzAlot commented 2 years ago

I know this is an older post but I can confirm most (if not all) of these are behaving this way. Don't know if this is something that would take up to much space if ever fixed or even if this is LE1 Patches problem to fix but just confirming nonetheless.

Herobrine24 commented 2 years ago

The entire diplomat office area at the embassies (BIOA_STA00 Start_STA20_08) is streamed in/out too early at the door that leads back to the embassy lobby (BIOA_STA00 Start_STA20_07) and the issue is clearly visible due to the office door automatically opening and having a large trigger area. This is fixable by setting BIOA_STA20_08 as a visible chunk in BioTriggerStream_140 in BioA_STA00.pcc and removing it as a loaded chunk in the same export.

Looking out of the office to the right, the door and button for Pallin's office and a light fixture next to the bar door are also not loaded in (BIOA_STA00 Start_STA20_09). This is fixable by setting BIOA_STA20_09 as a visible chunk in BioTriggerStream_94 in BioA_STA00.pcc and removing it as a loaded chunk in the same export. This way, one does not have to modify and ship BIOA_STA20_08.pcc while only rendering the layout and placeables of those rooms without the actual NPCs

Herobrine24 commented 2 years ago

@henbagle LE1CP-Streaming.zip

After 7 days I've managed to fix a majority of pop-in issues.

I've decided to just concentrate on things that I can fix using streaming states in order to avoid having to modify tons of files like in my initial approach in February. That way everything is limited to the *_00.pcc files of Ilos, Virmire, Feros, Citadel, Therum and Eden Prime. Noveria did not have any noticeable issues. As for any popping related to LODs, I've left untouched because it would necessitate modifying other files and would be detrimental to performance and isn't too drastic as the other stuff. The end product also didn't go over the 6GB memory limit that I set out for myself.

Along with this approach I've also fixed several loading hitches related to improper streaming setups from both OT and LE. And I also increased the amount of visible chunks on the Citadel at any given time, most notably in the Presidium, in order to increase detail over distance, such as NPCs that are within render bounds and minor objects like benches. The change Presidium "extension", according to my testing on my rig, impacted performance by an average of 10 frames at half of the locations within the Presidium when looking out into the entirety of it with Vsync disabled and a framerate cap of 240. Given the increased detail, I feel that sacrificing that amount of FPS is within margin. I've made sure to only add what was necessary in order to not add miniscule details that wouldn't be visible even by the minority who'd see it pop.

Here are a couple of issues I've encountered:

Patch Notes: