search

henbagle / LE1CommunityPatch

Issue tracker for the Community Patch mod for Mass Effect 1: Legendary Edition
13 stars 0 forks source link

Barrier GUI don't deplete. #96

Closed smoothgoal closed 2 years ago

smoothgoal commented 2 years ago

Desciption When barrier skill is active, the shields bar for Shepard goes white and no longer depletes, stays full even when shields go to 0. This is an entirely visual bug. Video: https://www.youtube.com/watch?v=EkUy51L2scQ Its not a problem for squad memebers.

To Reproduce Activate barrier, use grenades to damage yourself or let enemies damage you.

Expected behavior The white bar should deplete or shouldn't entirely hide the blue shields bar.

Saves Sent00_AutoSave.zip

henbagle commented 2 years ago

Fixed. In the PC_ME_HUD and ME_HUD scaleform files, the shield UI state is updated by referencing it by name - TeamBG.shepard.shieldFlash. When Barrier is applied, it transitions TeamBG.shepard to a different frame that contains a different UI element for the white barrier shield display. This UI element is not called shieldFlash, so the shield percentage is not updated. Fixed by changing the name of the barrier object in the second frame of TeamBG.shepard to shieldFlash in both PC_ME_HUD and ME_HUD. This is distributed via merge mod, in the same method as the #24 medigel fix.

Having two UI objects with the same name has not caused any adverse effects that I can detect. If this ends up being an issue, we can change the way the P-code sets the shield percentage to use a different name.

image