search

hendricius / pizza-dough

This recipe is dedicated to helping you make the best possible pizza dough for Neapolitan pizza.
https://pizza-calculator.the-bread-code.io/
MIT License
3.49k stars 185 forks source link

Pizza dough calculator #21

Closed pniedzwiedzinski closed 5 years ago

pniedzwiedzinski commented 5 years ago

Hey, I am learning frontend development and in my opinion the best way to learn something is to try it 😉. So what do you think if I do a redesign of your calculator? I already have an idea and you can see it here: https://www.figma.com/proto/fS1VRECfnZGE6TOg89goMmh2/Pizza-Dough-Calculator?node-id=2%3A0&viewport=695%2C443%2C0.73733&scaling=scale-down

hendricius commented 5 years ago

Haha, amazing. That looks pretty cool. I made a small video with some feedback. Hope it helps: https://app.hyfy.io/share/abZLowbOCmn/

pniedzwiedzinski commented 5 years ago

Input is not working, because it's only a prototype how it might look like 😉. I fixed some issues that you mentioned in the video and you can see it under that previous link. Still unsure about stroke around the text, I will leave that for later. So I will start working on that and we will see 😄

pniedzwiedzinski commented 5 years ago

Here's demo preview 😉 https://butterfly-pn.github.io/pizza-dough/

sm4rk0 commented 5 years ago

I've noticed a typo and created a pull request (for both repos).

hendricius commented 5 years ago

Good job. I love it.

I just had a few small suggestions for alignment on the final page where results are shown.

image

sm4rk0 commented 5 years ago

I suggest adding a step="50" to weight input and maybe a default value of 200.

pniedzwiedzinski commented 5 years ago

In my opinion, 50 is too big for step. The default value is a good idea 👍

sm4rk0 commented 5 years ago

OK, then it can be smaller, but 1g makes no sense. And also, default value for number of pizzas could be useful (1?).

hendricius commented 5 years ago

5 sounds like a good step size. How about 2 pizzas by default?