search

hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.
https://breadco.de/book
Creative Commons Attribution Share Alike 4.0 International
2.61k stars 133 forks source link

Do we need sans-serif ebooks ? #131

Closed cedounet closed 1 year ago

cedounet commented 1 year ago

The nice thing about ebook is that you can change font size and type of font... pick the one you like even. as we spend most of the build time doing ebooks, my polar bear friend is asking if we should really do it? pdf of course, but for ebooks... ? Had i thought of that before fixing the makefile maybe i would have a strong opinion, but now I am fine with either.

hendricius commented 1 year ago

It's a valid comment. Maybe we can switch to sans serif only? I was asked from a reader with accessibility issues. He could not easily read the serif version. Maybe it's better to only build sans-serif. Open to suggestions.

cedounet commented 1 year ago

On Wed, Jun 28, 2023 at 11:34:19AM -0700, Hendrik Kleinwaechter wrote:

It's a valid comment. Maybe we can switch to sans serif only? I was asked from a reader with accessibility issues. He could not easily read the serif version. Maybe it's better to only build sans-serif. Open to suggestions.

I dislike sans-serif when there is a lot of text... I find it hard to read. My preference would be:

book_serif.pdf
book_sans_serif.pdf
book_serif.epub/azw3/...

we can also leave the code for generating it all, just not build it by default.

C/

hendricius commented 1 year ago

That's a good idea. Maybe we only build it in the github action that uploads the documents to AWS S3 on merge to main?

cedounet commented 1 year ago

we want CI to catch errors early though ... I gave it a go and i don't understand why we don't save any time. I did not look at logs though

cedounet commented 1 year ago

Actually it goes down to 4m19 or from 10 to 12 min...

hendricius commented 1 year ago

That's pretty impressive 😎 . I agree - we want to catch the errors. But - building sans serif I assume should not cause that many errors? I assume running this check only on merge to main should be OK?

cedounet commented 1 year ago

Famous last words 🧐

I do not find tex4ht to be super robust, an impressive piece of work for sure, but LaTeX macro tend to break some seemingly unrelated things in another package relatively often…. Maybe I am being unfair but tex4ht is newer and seems to suffer from more of those problems.

if we can run this test before merging to main, then I think this is a good compromise.

cedounet commented 1 year ago

PR done, YOLO...