search

hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.
https://breadco.de/book
Creative Commons Attribution Share Alike 4.0 International
2.61k stars 133 forks source link

Use Lualatex #159

Closed cedounet closed 1 year ago

cedounet commented 1 year ago

In order to use open type fonts (OTF) we need to move towards a more modern TeX engine.

@hendricius I don't have ruby installed yet... so I only have the "raw" ouptut whihc looks fine but if you could test more that would be appreciated, look for weird looking characters, mostly in non-ASCII one like degrees or Umlaut/accents.

Thanks

C

hendricius commented 1 year ago

Loaf it. The font looks very nice!

cedounet commented 1 year ago

Looks like it broke the website :( I don’t have that in the CI as it only runs when merging to main… I will have a look for obvious things tomorrow.

C/

hendricius commented 1 year ago

@cedounet It seems like it the mrproper command that is not working somehow. Without it I can generate the website.

I wanted to make sure to clean the build before running the website command. If you check /website/makefile/ you can see the logic. I just call make in the other folder. Maybe mrproper is not needed?

cedounet commented 1 year ago

I sent a patch for that bug https://github.com/hendricius/the-sourdough-framework/pull/160

After i have another one for fixing the website makefile. Golden Rule mrproper is never needed, if you need it you have a bug in your makefile. 🐛

Once I manage to get ruby working I will send you the fixed makefile... or before 😄

cedounet commented 1 year ago

https://github.com/hendricius/the-sourdough-framework/pull/161 for a draft on the improved makefile

hendricius commented 1 year ago

@cedounet still having some small issues. Upon running make website it won't run again.

image

Only when removing rm -rf static_website_html/ the script will re-generate the website.

Do you have an idea what could cause this issue? Thank you!

cedounet commented 1 year ago

I would assume that bundle install shall be run only once? It is fine for you to delete first until I fix it though… or you can break the line with an extra target called bundle_install and add this as a dependency

hendricius commented 1 year ago

Yup. Correct. bundle install installs some ruby dependencies. But it would only need to be run once. Thanks! Just deleting the folder for now :-)

cedounet commented 1 year ago

https://github.com/hendricius/the-sourdough-framework/pull/165 work here.

The ruby code seems to be doing stuff that shall have been handled in the makefile. I am not really sure what was intended though.

Hope this works for you now 😸