hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.
https://breadco.de/book
Creative Commons Attribution Share Alike 4.0 International
2.57k stars 128 forks source link

Add graphic showcasing evolution of life #270

Closed hendricius closed 8 months ago

hendricius commented 8 months ago

After reading a really good book by Ed Young on microorganism I figured I update the history of sourdough bread a bit more.

image
cedounet commented 8 months ago

I am not sure i understand the scaling on your timeline? you normalize earth age to 1 year? IMO it would be clearer if you put 20M years ago etc...

I promise I will not be asking for a log scale 🤓

hendricius commented 8 months ago

@cedounet thanks for the Feedback! I fixed most of the issues 👍 . As a basis to calculate I used: "(4.54 billion years / 12 months = 0.3785 billion years/month". I also added it as a comment in the code 😎

cedounet commented 8 months ago

You might want to reword your dates as well to match American style https://editorsmanual.com/articles/dates-american-vs-british/

this is pretty much what I have in the Chicago manual of style… not ordinals.

if we ever want to translate then we should use datetime2 package. I would use it anyway as I would get the date format wrong without looking on the inter webs.

hendricius commented 8 months ago

You might want to reword your dates as well to match American style https://editorsmanual.com/articles/dates-american-vs-british/

this is pretty much what I have in the Chicago manual of style… not ordinals.

if we ever want to translate then we should use datetime2 package. I would use it anyway as I would get the date format wrong without looking on the inter webs.

Sweet! Thanks for the tip. I updated - hope I didn't miss something. datetime2 sounds like a good idea too. Let me see if I can add this with the next PR for the sourdough human timeline.

hendricius commented 8 months ago

Thanks! I fixed the issues. Also added pangea and squeezed it in. Awesome idea. Can you check one more time please? Thank you!

hendricius commented 8 months ago

Great idea 👍. Also thanks for the hint on make check.

On Mon 6. Nov 2023 at 10:20, cedounet @.***> wrote:

@.**** commented on this pull request.

Maybe run make check on it

I would add the scaling bottom left of the graph… 1 quarter represents 1 billion year about.

In book/history/sourdough-history.tex https://github.com/hendricius/the-sourdough-framework/pull/270#discussion_r1382648197 :

bread are, however, unknown. One of the most ancient preserved -sourdough breads has been excavated in Switzerland. -However, based on recent research, some scientists speculate that sourdough -bread had already been made in \num{12000}~BC in ancient Jordan~\cite{jordan+bread}. +sourdough breads has been excavated in Switzerland.~\cite{switzerland+bread}

Citation before the dot

— Reply to this email directly, view it on GitHub https://github.com/hendricius/the-sourdough-framework/pull/270#pullrequestreview-1714057643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGHNW26Y2GMWE6QKGBWU6DYC77KHAVCNFSM6AAAAAA6YLRFPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJUGA2TONRUGM . You are receiving this because you authored the thread.Message ID: @.***>

hendricius commented 8 months ago

As discussed, just added the time indicators to the chart. Or do you have a better idea to place them?

image
cedounet commented 8 months ago

I really like it now.

  1. Have you tried to use colours? That I think would make it less packed
  2. I would use double arrows <--> for ranges.
hendricius commented 8 months ago

Great idea 🙏🏻

On Mon 6. Nov 2023 at 22:59, cedounet @.***> wrote:

I really like it now. Have you tried to use colours?

— Reply to this email directly, view it on GitHub https://github.com/hendricius/the-sourdough-framework/pull/270#issuecomment-1794463774, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGHNW6Q6YNPJSKQRVX2KQDYDCYG3AVCNFSM6AAAAAA6YLRFPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGQ3DGNZXGQ . You are receiving this because you authored the thread.Message ID: @.***>

hendricius commented 8 months ago

@cedounet what do you think? I also didn't want to overdo the colors.

image
cedounet commented 8 months ago

Yeah it's a matter of balance... LGTM, we can always fine-tune later anyway.