search

hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.
https://breadco.de/book
Creative Commons Attribution Share Alike 4.0 International
2.57k stars 128 forks source link

Add a build on push to branch #307

Closed cedounet closed 6 months ago

cedounet commented 6 months ago

Make -j build_serif build_ebook as we had was good… now we only know if we break CI when doing a PR.

hendricius commented 6 months ago

Make -j build_serif build_ebook as we had was good… now we only know if we break CI when doing a PR.

Would it be OK to use the latest image for pushes? Else we'd need to build 1 image for each push too.

hendricius commented 6 months ago

@cedounet the pushes now always use the latest image - which is the one from the main branch. This way we save some polar bears and don't build a new docker image on every push. For pull requests we always build a new image (mostly from cache) and then publish it so that we can later on in theory revert back to that particular image and see if things broke with a particular PR.

cedounet commented 6 months ago

I meant build the book.

no actions are triggered when I push to a branch.. it should try to build the book so you know early you broke something.

cedounet commented 6 months ago

I re-open as i just pushed something to https://github.com/hendricius/the-sourdough-framework/tree/313-kobo-flowcharts and no actions is to be seen.

hendricius commented 6 months ago

Could you try to reintegrate and see if it fixes it?

cedounet commented 6 months ago

I had not ran git fetch before the merge... mea culpa