Small changes to Docker command and `.gitignore`

hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.

https://breadco.de/book

Creative Commons Attribution Share Alike 4.0 International

2.62k stars 136 forks source link

Small changes to Docker command and `.gitignore` #309

Closed sha1sum closed 9 months ago

sha1sum commented 9 months ago

Adds .DS_Store to .gitignore for Mac users.
Adds --rm option flag to docker command so that containers are removed when the process is finished rather than leaving a bunch of containers around.

cedounet commented 9 months ago

Can you please check why CI failed.

thanks.

sha1sum commented 9 months ago

@cedounet I can only assume it's something to do with permissions. It's getting a 403 forbidden when trying to upload something.

sha1sum commented 9 months ago

This is coming from my fork so I'm not sure that the Docker image will push because it's not running with the GitHub Actions token from this repo I don't think.

cedounet commented 9 months ago

Yeah that makes sense. I will let @hendricius to merge, but +1 from me.