search

hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.
https://breadco.de/book
Creative Commons Attribution Share Alike 4.0 International
2.57k stars 128 forks source link

Fix tiny typo in bread types. #339

Closed kdungs closed 5 months ago

kdungs commented 5 months ago

Moin Hendrik,

while reading through your amazing book, I stumbled over the tiniest of typos. Feel free to reject the PR and just fix it yourself. 😄 And keep up the great work!

Cheers, Kevin

cedounet commented 5 months ago

Did you cross-check with the numerous corrections that were made to the physical book ? https://discord.com/channels/1159886299243749477/1163969309807235092/1194759730736922735

Thanks!

C/

kdungs commented 5 months ago

Apologies, I'm not on the Discord and naïvely assumed that the GitHub repo would be the single source of truth 🙈. Feel free to close this if it's redundant.

cedounet commented 5 months ago

I will merge that one in any case... but my point was (unfortunately?) there is another ground truth. I reckon @hendricius said it was about 1000 changes that need to be merged back.

cedounet commented 5 months ago

@hendricius build of Docker image is broken 😢

hendricius commented 5 months ago

@cedounet is it broken in general, or just for this PR?

hendricius commented 5 months ago

Merging - will have a look at on the main branch

cedounet commented 5 months ago

The PR is very harmless… so expecting it is a bug with CI… interesting it built on main though but not on PR.

hendricius commented 5 months ago

@cedounet maybe a temporary glitch in the matrix. Fingers crossed.

cedounet commented 5 months ago

i was going to try it with the other one.. but unfortunately i pushed to main directly. So let me try again.

BTW, you should maybe disable push to main directly. 9 times out of 10 it is a mistake to do so.

hendricius commented 5 months ago

@cedounet I'll leave push to main there for now - with great power comes great responsibility 😎