search

hendricksonsarahl / voluntr

An app that matches nonprofits with volunteers
8 stars 0 forks source link

Added new splash image to Index and 'How Voluntr Works' section with icons #189

Closed hendricksonsarahl closed 7 years ago

hendricksonsarahl commented 7 years ago

this resolves issue #176

rylandbell commented 7 years ago

The design looks great! In the HTML for the index page, I noticed some odd nesting. With Bootstrap, divs with classes like col-xs-12 col-md-4 should be direct descendants of row divs. In the block of code between lines 20 and 41, you have several nested row classes, which are unnecessary (although it apparently works in this instance.) I'd recommend leaving the parent row center div, and rearranging all the col-xs-12 col-md-4 to be immediate children of it. @hendricksonsarahl

hendricksonsarahl commented 7 years ago

Thanks Ryland! I'll implement these changes before I merge it. Still new to bootstrap so I expected I would need to clean up a bit. I'll let you know if I have questions!

On Nov 2, 2017, at 4:43 PM, Ryland Bell notifications@github.com wrote:

The design looks great! In the HTML for the index page, I noticed some odd nesting. With Bootstrap, divs with classes like col-xs-12 col-md-4 should be direct descendants of row divs. In the block of code between lines 20 and 41, you have several nested row classes, which are unnecessary (although it apparently works in this instance.) I'd recommend leaving the parent row center div, and rearranging all the col-xs-12 col-md-4 to be immediate children of it. @hendricksonsarahl

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.