search

hendricksonsarahl / voluntr

An app that matches nonprofits with volunteers
8 stars 0 forks source link

added a filter error landing page #194

Closed AdamD-2096 closed 7 years ago

AdamD-2096 commented 7 years ago

added a filter error landing page that handles no opp and no zip errors added a little bootstrap but not much. good be greatly improved. but here is a start. maybe a good background image would be nice as well? references issue #149

hendricksonsarahl commented 7 years ago

Good thinking! We definitely need error handling messages, though the last time we discussed ideas for it I thought we planned to try flash messages in-page? That way the user can get feedback and make changes all in one place. Open to discussing the best way to handle these

On Nov 4, 2017, at 11:12 PM, Adam Duhamel notifications@github.com wrote:

@AdamD-2096 requested your review on: hendricksonsarahl/voluntr#194 added a filter error landing page.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

AdamD-2096 commented 7 years ago

oh.. i didn't hear about that.. and there is still an issue open for this. #149 the way i read it seems like a separate page.. but that is a good idea, especially for filters.. i can close this pull request and make a new issue and remove the old issue if you like.

AdamD-2096 commented 7 years ago

i'll just do that.. wasted work is worth it for a better solution

hendricksonsarahl commented 7 years ago

Awesome, thanks Adam! I think it was mentioned in passing during interview night, totally forgot to make a specific issue afterwards. Sounds like a good plan to me!