search

hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
118 stars 53 forks source link

[windows] Update ccache to 4.7 #109

Closed dcvz closed 2 years ago

dcvz commented 2 years ago

As mentioned in #88, ccache has made updates to further support the Windows environment. This bumps the version used to 4.7 which has the latest fixes.

jonashaag commented 2 years ago

There seem to be unrelated changes (logging and yarn lock file). Can you please make two separate PRs for that?

dcvz commented 2 years ago

There seem to be unrelated changes (logging and yarn lock file). Can you please make two separate PRs for that?

Sorted!

hendrikmuhs commented 2 years ago

Thanks for the PR! It seems something is wrong with your build setup. No problem! Can you reduce the PR to only have the changes in restore.ts or with other words: revert the js changes? I can fix the build afterwards, which I have to do anyway after merging dependabot changes.

dcvz commented 2 years ago

Thanks for the PR! It seems something is wrong with your build setup. No problem! Can you reduce the PR to only have the changes in restore.ts or with other words: revert the js changes? I can fix the build afterwards, which I have to do anyway after merging dependabot changes.

This is now done!

glebm commented 2 years ago

Nice! Looking forward to greatly sped-up Windows builds Is anything else blocking the merge?

glebm commented 2 years ago

Actually, might as well go straight to 4.7.2 instead of 4.7.0

hendrikmuhs commented 2 years ago

Thanks, merging it now, happily take another PR to bump ccache for windows to >= 4.7.2