search

hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
114 stars 52 forks source link

Fix #146: use compiler hash instead of volatile mtime #147

Closed janisozaur closed 1 year ago

janisozaur commented 1 year ago

This addresses issue where GitHub actions runners report different mtime for compiler causing incorrect cache misses

hendrikmuhs commented 1 year ago

I am willing to merge an optional setting.

compiler_check=content is documented to be slower.

It is a special case if the mtime is different for you, I think most users don't have that problem: The runner images change rarely. On a linux system the mtime of a package is not based on the install date but depends on the package creation date.

janisozaur commented 1 year ago

I would suggest setting it as default for macOS (I have seen it in other projects using github actions as well), but I don't know how. If you're happy with this suggestion, can you try implementing that?

janisozaur commented 1 year ago

I tried implementing that as a default for macOS.

krlmlr commented 1 year ago

If this is a mac-only issue, the implementation looks good to me. What about Windows?