search

hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
122 stars 54 forks source link

Move cache out of the worktree #165

Closed krlmlr closed 3 months ago

krlmlr commented 1 year ago

For #96.

krlmlr commented 1 year ago

This action in action: https://github.com/tidyverse/blob/actions/runs/6445932389/job/17500507262#step:6:3405 .

Any idea why sccache fails?

hendrikmuhs commented 1 year ago

Did you look at the test? Maybe you have to adapt he location at this line:

https://github.com/hendrikmuhs/ccache-action/blob/main/.github/workflows/tests.yml#L59

krlmlr commented 1 year ago

Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea?

hendrikmuhs commented 1 year ago

Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea?

yes, I think this is a good idea

krlmlr commented 3 months ago

Let's see how far we get with the current implementation after #217. I still think the cache shouldn't live inside the worktree, let's discuss when this becomes an issue.